Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdfw_services: psa_crypto: use new tags for pointer-to-const members #19808

Merged
merged 2 commits into from
Jan 14, 2025
Merged

sdfw_services: psa_crypto: use new tags for pointer-to-const members #19808

merged 2 commits into from
Jan 14, 2025

Conversation

jonathannilsen
Copy link
Contributor

@jonathannilsen jonathannilsen commented Jan 8, 2025 •
edited
Loading

Relevant changes are in the second commit.

The first commit is just regenerating zcbor code.

@jonathannilsen jonathannilsen requested review from a team as code owners January 8, 2025 16:26
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 8, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 8, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: a36dee5ae161f042d8efd9c96c847ea3982adad6

more details

sdk-nrf:

PR head: a36dee5ae161f042d8efd9c96c847ea3982adad6
merge base: aec6383d2d31332319493bab8b5364d62f0fad8a
target head (main): aec6383d2d31332319493bab8b5364d62f0fad8a
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (26) 
subsys
│  ├── sdfw_services
│  │  ├── services
│  │  │  ├── echo
│  │  │  │  ├── zcbor_generated
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── echo_service_decode.c
│  │  │  │  │  ├── echo_service_decode.h
│  │  │  │  │  ├── echo_service_encode.c
│  │  │  │  │  ├── echo_service_encode.h
│  │  │  │  │  │ echo_service_types.h
│  │  │  ├── psa_crypto
│  │  │  │  ├── Kconfig
│  │  │  │  ├── psa_crypto_service.cddl
│  │  │  │  ├── zcbor_generated
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── psa_crypto_service_decode.c
│  │  │  │  │  ├── psa_crypto_service_decode.h
│  │  │  │  │  ├── psa_crypto_service_encode.c
│  │  │  │  │  ├── psa_crypto_service_encode.h
│  │  │  │  │  │ psa_crypto_service_types.h
│  │  │  ├── reset_evt
│  │  │  │  ├── zcbor_generated
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── reset_evt_service_decode.c
│  │  │  │  │  ├── reset_evt_service_decode.h
│  │  │  │  │  ├── reset_evt_service_encode.c
│  │  │  │  │  ├── reset_evt_service_encode.h
│  │  │  │  │  │ reset_evt_service_types.h
│  │  │  ├── sdfw_update
│  │  │  │  ├── zcbor_generated
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── sdfw_update_service_decode.c
│  │  │  │  │  ├── sdfw_update_service_decode.h
│  │  │  │  │  ├── sdfw_update_service_encode.c
│  │  │  │  │  ├── sdfw_update_service_encode.h
│  │  │  │  │  │ sdfw_update_service_types.h

Outputs:

Toolchain

Version: 11349092be
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:11349092be_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 145
  • ✅ Integration tests
    • ✅ test-sdk-dfu
    • ⚠️ test-sdk-dfu
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@jonathannilsen jonathannilsen added this to the 2.9.0-nRF54H20 milestone Jan 9, 2025
@jonathannilsen jonathannilsen requested a review from a team as a code owner January 10, 2025 10:52
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 10, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@jonathannilsen
sdfw_services: regenerate zcbor encoders/decoders with current version
0670a23 
Regenerate code using the current zcbor version.

Signed-off-by: Jonathan Nilsen <[email protected]>
@jonathannilsen
sdfw_services: psa_crypto: use new tags for pointer-to-const members
a36dee5 
This lets the server loosen the required permissions when validating
pointers-to-const parameters so that only read permissions are required
for these.

Note that this CDDL update is not backwards compatible, and the
service version is bumped to 2.

Ref: NCSDK-31182

Signed-off-by: Jonathan Nilsen <[email protected]>
@github-actions github-actions bot removed the manifest label Jan 13, 2025
nordicjm
nordicjm approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flip the order of these commits, the changes to the source files should be before the re-generation of files using said source files, otherwise the history makes no sense

@jonathannilsen
Copy link
Contributor Author

Flip the order of these commits, the changes to the source files should be before the re-generation of files using said source files, otherwise the history makes no sense

Sorry if the commits/description were unclear on this, but the first commit is re-generating the code without any changes to the source files but using the latest zcbor version that is checked out by the manifest (partial duplicate of #16974). Then the second commit changes one of the source files and re-generates code based on that file in the same commit. I split it to try keeping the irrelevant diff in the first commit, but I can merge the two commits if you prefer.

@nordicjm
Copy link
Contributor

Flip the order of these commits, the changes to the source files should be before the re-generation of files using said source files, otherwise the history makes no sense

Sorry if the commits/description were unclear on this, but the first commit is re-generating the code without any changes to the source files but using the latest zcbor version that is checked out by the manifest (partial duplicate of #16974). Then the second commit changes one of the source files and re-generates code based on that file in the same commit. I split it to try keeping the irrelevant diff in the first commit, but I can merge the two commits if you prefer.

Fine to keep it as 2 commits since it's 2 operations not the 1 I assumed

@nordicjm nordicjm merged commit 4825324 into nrfconnect:main Jan 14, 2025
15 of 17 checks passed
@NordicBuilder NordicBuilder mentioned this pull request Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nordicjm nordicjm nordicjm approved these changes

@57300 57300 57300 approved these changes

Assignees
No one assigned
Labels
backport v2.9-nRF54H20-branch changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Milestone
2.9.0-nRF54H20-1
Development

Successfully merging this pull request may close these issues.
5 participants
@jonathannilsen @NordicBuilder @nordicjm @57300 @hakonfam